fix(react-router-dev): avoid duplicate stylesheet links for nested suspended routes#14793
Open
joseph0926 wants to merge 1 commit intoremix-run:devfrom
Open
fix(react-router-dev): avoid duplicate stylesheet links for nested suspended routes#14793joseph0926 wants to merge 1 commit intoremix-run:devfrom
joseph0926 wants to merge 1 commit intoremix-run:devfrom
Conversation
🦋 Changeset detectedLatest commit: 200ba23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be a problem caused by adding
#, similar to the previously submitted PR (#14687), so I attempted to fix it.Fixes duplicated stylesheet links in Framework mode for suspended components in nested routes
When reproducing the issue, I confirmed it does not occur in dev mode, but does occur when running the built app.
The behavior appears related to the forced-unique
#stylesheet href logic introduced to preserve dynamic-import CSS behavior.Changes
integration/vite-css-suspended-duplicate-test.tspackages/react-router-dev/vite/plugin.tsFixes #14754